Fix ClassCastException in HttpOperations#initShortId()
#3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `HttpOperations#initShortId()` could cause a `ClassCastException` if the underlying connection was replaced between checking its type and casting it to `AtomicLong`, for example if `ChannelOperations#terminate()` was called on another thread. See also: https://github.com/reactor/reactor-netty/blob/667f8c9cbf5a227a15f6d0a2f3aab7c4777613da/reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java#L515 Fixes reactor#3541
|
@joschi Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
IMHO this is an obvious fix, so no need to sign the CLA.
|
|
@pivotal-cla This is an Obvious Fix |
|
@joschi This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
violetagg
requested changes
Dec 11, 2024
reactor-netty-http/src/main/java/reactor/netty/http/HttpOperations.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Violeta Georgieva <[email protected]>
violetagg
approved these changes
Dec 11, 2024
violetagg
added a commit
that referenced
this pull request
Dec 11, 2024
Calling `HttpOperations#initShortId()` could cause a `ClassCastException` if the underlying connection was replaced between checking its type and casting it to `AtomicLong`, for example if `ChannelOperations#terminate()` was called on another thread. See also: https://github.com/reactor/reactor-netty/blob/667f8c9cbf5a227a15f6d0a2f3aab7c4777613da/reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java#L515 Fixes #3541 Co-authored-by: Violeta Georgieva <[email protected]>
violetagg
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
HttpOperations#initShortId()could cause aClassCastExceptionif the underlying connection was replaced between checking its type and casting it toAtomicLong, for example ifChannelOperations#terminate()was called on another thread.See also:
reactor-netty/reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java
Line 515 in 667f8c9
Fixes #3541